[naga wgsl-in] Fill out error message for deep nesting. #5486
Conversation
In the WGSL front end, clarify error message for deeply nested statements.
There was a problem hiding this comment.
I'm currently working on a few of our Firefox timeline items right now, so I won't be prioritizing this for the next couple of days, but I definitely intend to get back to this!
I'm actually surprised that you wanted to tweak this. Could you help me understand what your goals for revising were?
| @@ -775,10 +775,10 @@ impl<'a> Error<'a> { | |||
| ] | |||
| }, | |||
| Error::ExceededLimitForNestedBraces { span, limit } => ParseError { | |||
| message: "brace nesting limit reached".into(), | |||
| labels: vec![(span, "limit reached at this brace".into())], | |||
| message: "Statements nested too deeply".into(), | |||
There was a problem hiding this comment.
issue: The capitalized casing, for better or worse, is not consistent with other diagnostics.
| message: "Statements nested too deeply".into(), | |
| message: "statements nested too deeply".into(), |
There was a problem hiding this comment.
This feedback also applies to the notes field.
| notes: vec
|
Boop from triage |
|
I don't want to change this any more. |
In the WGSL front end, clarify error message for deeply nested statements.
@ErichDonGubler I was going to push this as a suggestion to the PR but forgot to. Only take it if you like it.