Improve the polyfill for workgroup variable zero initialization #5521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #4592
Description
Implements the suggestion in #4592 (comment)
I have implemented this for Spir-v, GLSL and HLSL.
Having implemented this, I have found enough issues that I am unsure about continuing this:
If someone else wants to take this on, feel free.
Testing
I have added a new test which tests the worse case of the old initialisation.
Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
N/A--target wasm32-unknown-emscripten
N/Acargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.