Remove lifetime dependency of ComputePass
to its parent command encoder
#5620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
RenderPass
make it difficult to use. #1453Part of a series towards lifetime removal on compute passes:
wgpu::ComputePass
) #5432wgpu::ComputePass
methods #5570ComputePass
to its parent command encoder #5620Description
ComputePass
had a static lifetime dependency to its parent encoder. This PR removes this (ComputePass<'a>
->ComputePass
) by havingComputePass
own an Arc to its parent encoder. A side-effect of this is thatComputePass
creation can now fail in theory (if an invalid id is passed or commandbuffer allocation fails for some reason).Another wide reaching side effect is that command encoders can now be in a
Locked
state. (via WebGPU spec) any operation on a locked command encoder fails and makes the encoder invalid.The last remaining lifetime dependency to resolve on
ComputePass
after this PR is inComputePassTimestampWrites<'a>
: We currently don't bump the reference count on the referencedQuerySet
. This is in fact more of a pre-existing bug since destroying a QuerySet after recording it in a ComputePass and before closing the pass already causes issues!Testing
Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.Add change toCHANGELOG.md
. See simple instructions inside file.