-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure safety of indirect dispatch #5714
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
018b23b
to
a5bebb0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ac3f089
to
36281af
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
b57350e
to
e0bd41a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ab03bc6
to
abeb863
Compare
e227fdf
to
33843df
Compare
33843df
to
d82ca61
Compare
d82ca61
to
2ed3211
Compare
431ca4a
to
28bef9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See Atomic issue and other small nits
EDIT from @ErichDonGubler: added a link for atomic issue
3b5533f
to
fcb7658
Compare
80e374f
to
1624e99
Compare
1624e99
to
ec6f138
Compare
01dab26
to
d30c4b2
Compare
d30c4b2
to
208cc09
Compare
by injecting a compute shader that validates the content of the indirect buffer
208cc09
to
66c1892
Compare
I will just squash and merge, losing 6619f3a is not the end of the world. |
I'm tracking
I'm guessing it's this binding
being used on line 288:
...so for some reason in my case |
Ensure safety of indirect dispatch by injecting a compute shader that validates the content of the indirect buffer.
Part of #2431.
Depends on #6318.