Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reexport InternalCounters, HalCounters and CoreCounters in wgpu #6022

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Reexport InternalCounters, HalCounters and CoreCounters in wgpu #6022

merged 1 commit into from
Jul 23, 2024

Conversation

nical
Copy link
Contributor

@nical nical commented Jul 23, 2024 •
edited
Loading

Description

I forgot to reexport them in the original PR, which means user that want to manipulate them have to manually keep a wgpu_type dependency in sync.

Checklist

  • Run cargo fmt.
  • Run cargo clippy.
  • Run cargo xtask test to run tests.

@nical nical requested a review from a team as a code owner July 23, 2024 13:28
@teoxoy teoxoy merged commit 34d492a into gfx-rs:trunk Jul 23, 2024
25 checks passed
@nical nical deleted the export-counters branch July 23, 2024 15:07
@Wumpf Wumpf added the PR: needs back-porting PR with a fix that needs to land on crates label Jul 24, 2024
cwfitzgerald pushed a commit to cwfitzgerald/wgpu that referenced this pull request Jul 31, 2024
@nical @cwfitzgerald
Reexport InternalCounters, HalCounters and CoreCounters in wgpu (gfx-…
24aeee2 
…rs#6022)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoxoy teoxoy teoxoy approved these changes

Assignees
No one assigned
Labels
PR: needs back-porting PR with a fix that needs to land on crates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nical @teoxoy @Wumpf