Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate derived BGLs #6049

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Deduplicate derived BGLs #6049

merged 1 commit into from
Jul 25, 2024

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Jul 25, 2024

Connections
Fixes #6037.
Reverts 60b42f9.

Testing
Added a test.

@teoxoy teoxoy requested a review from a team as a code owner July 25, 2024 11:45
@teoxoy
Copy link
Member Author

teoxoy commented Jul 25, 2024

@sagudev could you give this PR a try?

sagudev added a commit to sagudev/servo that referenced this pull request Jul 25, 2024
@sagudev
test gfx-rs/wgpu#6049
09deb21 
Signed-off-by: sagudev <[email protected]>
sagudev added a commit to sagudev/servo that referenced this pull request Jul 25, 2024
@sagudev
test gfx-rs/wgpu#6049 (webgpu)
00ec3fa 
{"fail_fast": false, "matrix": [{"name": "WebGPU CTS", "workflow": "linux", "wpt_layout": "2020", "profile": "production", "unit_tests": false, "wpt_tests_to_run": "_webgpu"}]}
@sagudev
Copy link
Contributor

sagudev commented Jul 25, 2024 •
edited
Loading

@sagudev could you give this PR a try?

LGTM:

OK /_webgpu/webgpu/cts.https.html?q=webgpu:api,validation,encoding,programmable,pipeline_bind_group_compat:default_bind_group_layouts_never_match,render_pass:*

PASS [expected FAIL] subtest: :pipelineType="auto0";bindingType="auto0";swap=true;empty=false;renderCommand="draw"
PASS [expected FAIL] subtest: :pipelineType="auto0";bindingType="auto0";swap=true;empty=false;renderCommand="drawIndexed"
PASS [expected FAIL] subtest: :pipelineType="auto0";bindingType="auto0";swap=true;empty=false;renderCommand="drawIndirect"
PASS [expected FAIL] subtest: :pipelineType="auto0";bindingType="auto0";swap=true;empty=false;renderCommand="drawIndexedIndirect"
PASS [expected FAIL] subtest: :pipelineType="auto0";bindingType="auto0";swap=true;empty=true;renderCommand="draw"
PASS [expected FAIL] subtest: :pipelineType="auto0";bindingType="auto0";swap=true;empty=true;renderCommand="drawIndexed"
PASS [expected FAIL] subtest: :pipelineType="auto0";bindingType="auto0";swap=true;empty=true;renderCommand="drawIndirect"
PASS [expected FAIL] subtest: :pipelineType="auto0";bindingType="auto0";swap=true;empty=true;renderCommand="drawIndexedIndirect"

try run: https://github.com/sagudev/servo/actions/runs/10093551683/job/27911589051

@teoxoy teoxoy enabled auto-merge (rebase) July 25, 2024 15:58
@teoxoy teoxoy merged commit 03f6d24 into gfx-rs:trunk Jul 25, 2024
25 checks passed
@teoxoy teoxoy deleted the deduplicate-derived-BGLs branch July 25, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nical nical nical approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some bindgroups do not get deduplicated
3 participants
@teoxoy @sagudev @nical