Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker simplifications #6073

Merged
merged 9 commits into from
Aug 3, 2024
Merged

Tracker simplifications #6073

merged 9 commits into from
Aug 3, 2024

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Aug 2, 2024

Connections
-

Description
Various tracker simplifications (see each individual commit for details).

Testing
By existing tests in CI.

PR doesn't need to be squashed, each commit builds by itself.

The render bundle resources are already kept alive by the render bundle itself, there is no need to add them.
The resources inside `StatelessBindGroupState` are never merged with any other tracker.
Also removes the `StatelessBindGroupState` since it does the same thing.
…gle`

Also change it's definition to take an owned `Arc`. This makes these functions consistent with the other trackers.
@teoxoy teoxoy self-assigned this Aug 2, 2024
@teoxoy teoxoy requested a review from a team as a code owner August 2, 2024 18:20
@teoxoy teoxoy changed the title Tracker improvements Tracker simplifications Aug 2, 2024
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing stuff!

wgpu-core/src/track/mod.rs Show resolved Hide resolved
@teoxoy teoxoy merged commit 7b4cbc2 into gfx-rs:trunk Aug 3, 2024
25 checks passed
@teoxoy teoxoy deleted the tracker-refactors branch August 3, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants