[wgpu-hal] Change the DropGuard API in Vulkan and GLES to a callback-based one.
#6164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
requested changes
Aug 26, 2024
jerzywilczek
force-pushed
the
trunk
branch
3 times, most recently
from
327dbc9
to
bc0baff
Compare
This patch also unifies the behavior of the the `DropGuard`-ish constructs in the Vulkan-based implementation.
|
Pushed c2563dc to the impending squash-merge so that CI passes and actually does the merge. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch also unifies the behavior of the the
DropGuard-ish constructs in the Vulkan and GLES implementations.Connections
A change discussed in #6142. Closes #6142.
Description
Previously, when creating some wgpu structs from raw Vulkan or GLES counterparts, it was sometimes possible to provide a
DropGuard, which would signal when the wgpu struct was dropped and the underlying structure could be cleaned up. Unfortunately, the behavior was very inconsistent across different*_from_rawfunctions. This patch unifies this behavior switching to a callback-based approach.Testing
Things still compile and there is no difference in test passes.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptenThis just fails with many errors
cargo xtask testto run tests.41 tests fail on my PC, but they also fail without my changes.
CHANGELOG.md. See simple instructions inside file.