Make bind group an Option for set_bind_group calls. #6216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradwerth
force-pushed
the
clearBindGroup
branch
from
e36c9b6
to
f800842
Compare
This is just an API change for all the "set_bind_group" calls. Calls that pass a Some() argument should have unchanged behavior. The None cases are left as TODOs.
bradwerth
force-pushed
the
clearBindGroup
branch
from
f800842
to
c46d5f2
Compare
nical
approved these changes
Sep 6, 2024
|
I'd rather use Into<Option> so that the caller does not need to wrap it in Some. |
I don't think this feedback should block this PR, but if you feel strongly about it, I'd encourage you to file an issue for further discussion. |
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just an API change for all the "set_bind_group" calls. Calls that pass a
Some()argument have unchanged behavior. TheNonecases are left as TODOs.Connections
Issue #4738
Description
set_bind_groupnow takesOption<&BindGroup>.Testing
Existing tests, player scenes, and examples are all updated to use the new syntax.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.