Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

naga: Don't consider per-polygon inputs to be subgroup uniform #6276

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

magcius
Copy link
Contributor

@magcius magcius commented Sep 15, 2024

Implementations can absolutely pack multiple triangles per subgroup.

Fixes #6270.

Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories

Description
Describe what problem this is solving, and how it's solved.

Testing
Explain how this change is tested.

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Implementations can absolutely pack multiple triangles per subgroup.

Fixes gfx-rs#6270.
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I have the experience to give this one a boop

@cwfitzgerald cwfitzgerald merged commit 390a416 into gfx-rs:trunk Sep 22, 2024
27 checks passed
ErichDonGubler added a commit to erichdongubler-mozilla/wgpu that referenced this pull request Oct 25, 2024
ErichDonGubler added a commit to erichdongubler-mozilla/wgpu that referenced this pull request Oct 29, 2024
ErichDonGubler added a commit to erichdongubler-mozilla/wgpu that referenced this pull request Oct 29, 2024
ErichDonGubler added a commit to erichdongubler-mozilla/wgpu that referenced this pull request Oct 30, 2024
ErichDonGubler added a commit to erichdongubler-mozilla/wgpu that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non uniform indices are not always properly handled by naga
2 participants