Attempted fix for main example getting stuck when -n -2 and --interactive #2767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
ghost
reviewed
Aug 24, 2023
slaren
approved these changes
Aug 24, 2023
akawrykow
pushed a commit
to akawrykow/llama.cpp
that referenced
this pull request
Aug 29, 2023
…ganov#2767) * Fix for main example getting stuck when -n -2 and --interactive * Add a comment so future generations may suffer less.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure this is the correct fix (seems fairly likely though since setting
n_remainto-2looks pretty weird).Closes #2754