readme: improve readme for Llava-1.6 example #6044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
approved these changes
Mar 14, 2024
NeoZhangJianyu
pushed a commit
to NeoZhangJianyu/llama.cpp
that referenced
this pull request
Mar 15, 2024
Co-authored-by: Jian Liao <[email protected]>
hodlen
pushed a commit
to hodlen/llama.cpp
that referenced
this pull request
Apr 1, 2024
Co-authored-by: Jian Liao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a crucial update to the README.md file for the Llava 1.6 example. It addresses an oversight in the setup instructions.
Changes
Added a missing step in the setup instructions that involves installing the necessary Python dependencies for the llava 1.6example. This step is essential for users to correctly set up and run the Llava 1.6 example on their local environment.
Proposed Change
This line has been inserted at an appropriate place in the README.md to ensure a logical flow of the setup instructions. The addition of this installation step ensures that users have all the required dependencies installed, which are critical for the successful execution of the llava example.
Rationale
The omission of this step could lead to confusion or errors when users attempt to run the example, as the required Python packages would not be installed.