chore: enable require-error rule from errorlint linter on pkg folder (a…

…rgoproj#18691)

Signed-off-by: Matthieu MOREL <[email protected]>

.golangci.yaml

@@ -3,7 +3,7 @@ issues:
     - SA1019
     - SA5011
   exclude-rules:
-    - path: "(applicationset|cmpserver|controller|pkg|reposerver)/"
+    - path: "(applicationset|cmpserver|controller|reposerver)/"
       text: "require-error:"
       linters:
         - testifylint

pkg/apiclient/apiclient_test.go

@@ -4,13 +4,14 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
 func Test_parseHeaders(t *testing.T) {
 	t.Run("Header parsed successfully", func(t *testing.T) {
 		headerString := []string{"foo:", "foo1:bar1", "foo2:bar2:bar2"}
 		headers, err := parseHeaders(headerString)
-		assert.NoError(t, err)
+		require.NoError(t, err)
 		assert.Equal(t, "", headers.Get("foo"))
 		assert.Equal(t, "bar1", headers.Get("foo1"))
 		assert.Equal(t, "bar2:bar2", headers.Get("foo2"))
@@ -27,7 +28,7 @@ func Test_parseGRPCHeaders(t *testing.T) {
 	t.Run("Header parsed successfully", func(t *testing.T) {
 		headerStrings := []string{"origin: https://foo.bar", "content-length: 123"}
 		headers, err := parseGRPCHeaders(headerStrings)
-		assert.NoError(t, err)
+		require.NoError(t, err)
 		assert.Equal(t, []string{" https://foo.bar"}, headers.Get("origin"))
 		assert.Equal(t, []string{" 123"}, headers.Get("content-length"))
 	})