Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to improve Date Sorting by pre-parsing date items only once #1479

Merged
merged 3 commits into from
Sep 29, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Sep 29, 2024

fixes #1469

Copy link

stackblitz bot commented Sep 29, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (88e4372) to head (8c05360).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1479   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          938       945    +7     
  Branches       317       318    +1     
=========================================
+ Hits           938       945    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit bffc3ee into master Sep 29, 2024
4 checks passed
@ghiscoding ghiscoding deleted the perf/improve-date-sorting-speed branch September 29, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slow Sorting on datetime Column with dataset around 50k Records in SlickGrid
1 participant