chore(deps): upgrading lib to angular version 12

[sapnildessai]

#769 : Angular 12 support

[ghiscoding]

There seems to be lot of issues with the Jest unit tests, I'm not sure if it's because I didn't update Angular-Jest in a while but there's definitely something wrong here.

Test Suites: 31 failed, 135 passed, 166 total
Tests:       738 failed, 3 skipped, 2248 passed, 2989 total

[sapnildessai]

This is strange. When I run npm test on my local system it works pretty fine. I will take a look

[ghiscoding]

this line got removed and might be causing the Jest unit tests to fail on CircleCI, the error also seem to show it uses some minified code unless I'm not reading it correctly

[ghiscoding]

@sapnildessai can you put back that line that I've identified in the last comment and see if that helps.

[sapnildessai]

Yes. Added it back

[ghiscoding]

different error now, can you remove the flatpickr from these 2 Filters component since as it says it will always be true anyway. I'll soon rewrite them anyway to JavaScript native element instead of jQuery

[codecov]

Codecov Report

Merging #771 (b1f1252) into master (2462c1b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #771   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          161       161           
  Lines        11280     11280           
  Branches      4022      4022           
=========================================
  Hits         11280     11280           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2462c1b...b1f1252. Read the comment docs.

[ghiscoding]

now we're in business, it all works now 😃

Was that line removal "emitDecoratorMetadata": true produced by running ng update?
What might be better is to move that flag into the tsconfig.spec.json, which is the one used by Jest, and still remove it from the main tsconfig.json

[sapnildessai]

Yay!! Yes it was added by ng update. Yes, let's remove it from main tsconfig and add it to spec json file and see.

[ghiscoding]

that doesn't seem to work, so let's put it back to when it passed and I'll look at fixing it in future PR (unless you want to troubleshoot it). Thanks a lot for the great contribution here 👍

[ghiscoding]

@sapnildessai hey so I don't think you replied to question, I would just like to confirm... have you also tried the Excel Export (which was that issue related to)?

[sapnildessai]

Hey. Sorry which issue are you taking about? I haven't tried excel export after the upgrade.

[ghiscoding]

the issue #769, that other user wrote this

I have upgraded my application to angular12. Am using server side slick grid of 2.29.1 . But Slick grid is working fine except export to excel option..

[sapnildessai]

No I haven't tried. Let me forcefully upgrade demo project and try it locally.

[sapnildessai]

I have verified that excel export is working fine after upgrading to angular 12. I did a force update on the demo fork.