Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styling): add Dark Mode grid option #1407

Merged
merged 2 commits into from
Mar 2, 2024
Merged

feat(styling): add Dark Mode grid option #1407

merged 2 commits into from
Mar 2, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Mar 2, 2024

  • add a darkMode grid option, there are a couple of things to note:
  • SVG icon color is a lighter gray color because the color is shared for both light/dark mode, that is because the current code is setting the SVG fillColor with the original icon color SASS variable and fillColor cannot be overiden. There is a way to fix this by converting all SVG to pure CSS but that is most probably a breaking change to postpone for next major version
  • also Dark Mode will not be switching automatically by browser media, the reason why we use a grid option is because for some elements like (columnPicker, gridMenu, longTextEditor, ...) are appended to the DOM body. So for that reason, it is a grid option that must be toggled by the user. For the users who do want to toggle dark mode automatically, it could be changed by code and developers must implement that themselves.

Copy link

stackblitz bot commented Mar 2, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (9597c65) to head (108cbdb).

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1407     +/-   ##
========================================
+ Coverage    99.8%   99.8%   +0.1%     
========================================
  Files         199     199             
  Lines       21560   21597     +37     
  Branches     7205    7222     +17     
========================================
+ Hits        21496   21533     +37     
+ Misses         64      58      -6     
- Partials        0       6      +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding changed the title feat(styling): add Dark Mode option feat(styling): add Dark Mode grid option Mar 2, 2024
@ghiscoding ghiscoding merged commit 855151b into master Mar 2, 2024
8 checks passed
@ghiscoding ghiscoding deleted the feat/dark-mode branch March 2, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant