Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load the un-detailed letterbox list page in order to be able to also load watchlists. #42

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

samueljim
Copy link
Contributor

@samueljim samueljim commented Jun 24, 2024

The downside of this is that we don't get to the movies year here so we have to visit every single page to get the movie year which slows down at the script's runtime.

…oad watch lists.

The downside of this is that we don't get to the movies here so we have to visit every single page which slows down at the script's runtime.
@ghomasHudson
Copy link
Owner

ghomasHudson commented Jun 24, 2024

Thanks for the pull request - this looks awesome.

What I would suggest is that if the list is not a wishlist, we use the existing method using the details version (if the imdb_id_filter flags isn't set). This would allow things to be fast when they can be.

If it's a wishlist or imdb_id_filter is true, then we do the full search.

@samueljim
Copy link
Contributor Author

agreed. i just wanted to have less code but faster is better

@samueljim samueljim changed the title Load the un-detailed letterbox list page in order to be able to also load watch lists. Load the un-detailed letterbox list page in order to be able to also load watchlists. Jun 24, 2024
@ghomasHudson ghomasHudson merged commit a6c073b into ghomasHudson:master Jun 25, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants