Add a button / hook for reverting to default settings #25
Conversation
src/SetHo.hs
Outdated
| @@ -194,6 +204,9 @@ runSetter mconfig rootName initialValue userPollForNewMessage sendRequest userCo | |||
|
|
|||
| _ <- on buttonDiff Gtk.buttonActivated printDiff | |||
|
|
|||
| _ <- on buttonRevertToDefaults Gtk.buttonActivated | |||
| ((getLatestStaged >>= revertToDefaults) *> takeLatestUpstream) | |||
There was a problem hiding this comment.
I haven't looked at this code in a while, but I don't immediately understand this. Can you add a short comment on the use case? Specifically:
- why do you need the latest staged DTree in order to revert to defaults?
- why do you call takeLatestUpstream afterwards? in a GCS use-case the userRevertToDefaults won't have an affect by the time takeLatestUpstream is called, is that right?
There was a problem hiding this comment.
The reason to call takeLatestUpstream was so that reverting to defaults in the upstream system would also revert the staged values. It appears you are correct that this doesn't work as I'd hoped. I've deleted it; the user will just have to revert the staged values with a separate button press.
src/SetHo.hs
Outdated
| @@ -39,8 +39,8 @@ defaultSetHoConfig = | |||
| } | |||
|
|
|||
| -- | fire up the the GUI | |||
| runSetter :: Maybe SetHoConfig -> String -> DTree -> IO (Maybe (Int, DTree)) -> (Int -> IO ()) -> (Int -> DTree -> IO ()) -> IO () | |||
| runSetter mconfig rootName initialValue userPollForNewMessage sendRequest userCommit = do | |||
| runSetter :: Maybe SetHoConfig -> String -> DTree -> IO (Maybe (Int, DTree)) -> (Int -> IO ()) -> (Int -> DTree -> IO ()) -> (Int -> DTree -> IO ()) -> IO () | |||
There was a problem hiding this comment.
This breaks the binary in the examples directory, can you please update it?
There was a problem hiding this comment.
I'm unable to figure out with Cabal how to actually build this example. I nixified all the dependencies and can build the library, but:
peddie@jaidee:Plot-ho-matic(master☠)$ nix-shell --pure shell.nix --run "ghcid --command 'cabal v2-build set-example'"
Loading cabal v2-build set-example ...
Resolving dependencies...
Build profile: -w ghc-8.10.4 -O1
In order, the following will be built (use -v for more details):
- Plot-ho-matic-0.12.2.3 (exe:set-example) (configuration changed)
Configuring executable 'set-example' for Plot-ho-matic-0.12.2.3..
Warning: The package has an extraneous version range for a dependency on an
internal library: Plot-ho-matic >=0 && ==0.12.2.3, Plot-ho-matic >=0 &&
==0.12.2.3. This version range includes the current package but isn't needed
as the current package's library will always be used.
Preprocessing executable 'set-example' for Plot-ho-matic-0.12.2.3..
Building executable 'set-example' for Plot-ho-matic-0.12.2.3..
Command "cabal v2-build set-example" exited unexpectedly with error message: as the current package's library will always be used.
The incomplete error message, combined with the problematic version bounds on Plot-ho-matic which appear nowhere in the actual .cabal file, make me think this might be a cabal bug (shocker). Removing Plot-ho-matic from the build-depends: field of the executable does not solve the problem.
There was a problem hiding this comment.
haskell/cabal#5119 looks like it is a bug in cabal.
There was a problem hiding this comment.
Anyway, I think I fixed the example, but I can't check that it compiles thanks to cabal.
There was a problem hiding this comment.
I checked this with stack as recommended after rebasing on master, and it works.
peddie
force-pushed
the
revert-to-defaults
branch
from
c181d5a
to
726ca7a
Compare
peddie
force-pushed
the
revert-to-defaults
branch
from
726ca7a
to
9949c2e
Compare
No description provided.