Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow scriptlets being used as resources #4393

Open
seia-soto opened this issue Oct 26, 2024 · 0 comments · May be fixed by #4394
Open

Allow scriptlets being used as resources #4393

seia-soto opened this issue Oct 26, 2024 · 0 comments · May be fixed by #4394
Assignees
@seia-soto
Labels
bug

Comments

@seia-soto
Copy link
Member

This issue is separated from #4392.

Since v1.34, it's not possible to use scriptlets as redirect resources. We completely separated those two things to make things clear.

However, that change disabled an ability to use scriptles being used as resources and we're updating the implementation to be aligned with the uBo behavior.
@seia-soto seia-soto added the bug label Oct 26, 2024
@seia-soto seia-soto self-assigned this Oct 26, 2024
seia-soto added a commit to seia-soto/adblocker that referenced this issue Oct 26, 2024
@seia-soto
fix: allow scriptlet with
b3cba97 
refs https://github.com/gorhill/uBlock/wiki/Resources-Library
refs ghostery#4392
fixes ghostery#4393
@seia-soto seia-soto mentioned this issue Oct 26, 2024
Open
seia-soto added a commit to seia-soto/adblocker that referenced this issue Oct 26, 2024
@seia-soto
fix: allow scriptlets being used as resources
dafb57d 
refs https://github.com/gorhill/uBlock/wiki/Resources-Library
refs ghostery#4392
fixes ghostery#4393
@seia-soto seia-soto linked a pull request Oct 26, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seia-soto seia-soto

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow scriptlets being used as resources seia-soto/adblocker
1 participant
@seia-soto