Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not disable TLS 1.3 or allow insecure TLS versions #39

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

dhwed
Copy link
Contributor

@dhwed dhwed commented Jul 6, 2020

Rather than setting the ServicePointManager.SecurityProtocol to a specific set of values, this just adds TLS 1.2. The old approach was enabling the insecure TLS 1.0 and 1.1 protocols globally for all requests made by the application that used this method, and it was also removing TLS 1.3 support.

Also, applications targeting .NET Framework 4.7 or later have a default value of 0 (SecurityProtocolType.SystemDefault), which lets the OS control which TLS versions are allowed. This will allow TLS 1.2 by default, so it does not need to be changed.

The "correct" solution here is not to change the ServicePointManager.SecurityProtocol value at all, as it changes global static configuration and that should not be done in a library. But, I understand the desire to make things "just work", and I think this is a decent compromise.

@giacomelli giacomelli merged commit 0fe2d45 into giacomelli:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants