Update to dotnetstandard2.0 #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrated HelpSharp code withing SalesforceSharp & removed HelperSharp dependency due to its target framework conflicts. Updated all nuget references to latest.
|
I'm not familiar with cake runner, but the current setup seems to be targeting .net framework which might explain why units tests are unable to discover the internal functions despite having internalvisibleto setup in the dotnetstandard project. I do not have any build issues with msbuild on my local machine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated salesforcesharp to dotnetstandard2.0 so that it can be utilized in dotnet core & dotnet framework (4.6.1+).
Changes:
I've removed pdb & xml file details from nuspec. Support for adding them in the build file is currently up in the air New project system doesn't copy PDBs from packages. It is said to be fixed in .net6.