Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changelog #344

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Add changelog #344

merged 1 commit into from
Mar 3, 2020

Conversation

tfussell
Copy link
Contributor

@tfussell tfussell commented Mar 3, 2020

To prepare for the (probably) final dep-based release, we need a changelog to keep track of versions.

@tfussell tfussell self-assigned this Mar 3, 2020
@tfussell tfussell requested a review from a team March 3, 2020 17:19
MarcelMue
MarcelMue approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@MarcelMue MarcelMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me.

@tfussell tfussell merged commit 9fbad9e into master Mar 3, 2020
@tfussell tfussell deleted the add-changelog branch March 3, 2020 20:18
@kopiczko
Copy link
Member

kopiczko commented Mar 4, 2020

We still don't have v0.1.0 tag. Can I also ask to make releases a separate PR with a name suggesting this will create a new release? Then it's easier for people to realise their changes are included or not.

@kopiczko
Copy link
Member

kopiczko commented Mar 4, 2020

I see this #319 (comment). Then it's confusing we have 0.1.0 in changelog. It should be Unreleased IMO. Also Unreleased section is missing.

@tfussell tfussell mentioned this pull request Mar 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcelMue MarcelMue MarcelMue approved these changes

Assignees

@tfussell tfussell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tfussell @kopiczko @MarcelMue