Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix application crd errors #364

Merged
merged 4 commits into from
Mar 20, 2020
Merged

Fix application crd errors #364

merged 4 commits into from
Mar 20, 2020

Conversation

rossf7
Copy link
Contributor

@rossf7 rossf7 commented Mar 20, 2020

This fixes errors on boot in app-operator and chart-operator. The openapi validation root element needs to be of type object.

	/Users/rossf7/.gvm/pkgsets/go1.13.1/global/src/github.com/giantswarm/chart-operator/vendor/github.com/giantswarm/k8sclient/k8scrdclient/k8scrdclient.go:178: spec.validation.openAPIV3Schema.type: Required value: must not be empty at the root
	not established error

See upstream issue. kubernetes/kubernetes#81445

@rossf7 rossf7 self-assigned this Mar 20, 2020
@rossf7 rossf7 requested review from a team, xh3b4sd, mig4 and anvddriesch and removed request for a team March 20, 2020 18:14
@rossf7
Copy link
Contributor Author

rossf7 commented Mar 20, 2020

Going with a ping as these errors on boot are blocking me in app-operator and chart-operator.

@xh3b4sd Can you hold off merging the go modules change till I've released 0.1.2?

@rossf7 rossf7 merged commit b7eb06a into master Mar 20, 2020
@rossf7 rossf7 deleted the fix-application-crd-errors branch March 20, 2020 18:23
@angelbarrera92
Copy link

I know is not fully related, but if you try to deploy:

Thanks google + github for this awesome "indexing engine"!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants