-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump generator versions and add support for --name-mappings #149
Conversation
8569143
to
f5c6aed
Compare
@gibahjoe please review. Would you like to see addition changes? |
@DmitrySboychakov A new version of the OpenAPI generator and cli were just released. Please consider updating this PR so we can get the latest version right away. It contains some fixes we need so it would be greatly appreciated. Thanks |
@tjarvstrand yes, I am aware. I'd like to see the review from @gibahjoe first and I can prepare re-worked and updated PR |
Thank you but could you please remove binary file? As I only trust binary file from author |
Sorry guys, got busy with studies. This PR looks good. Just a review to get through |
/// Makes even arrays that are not listed as being required in your OpenAPI "required" | ||
/// but making them always generate a default value of [] | ||
final bool? nullSafeArrayDefault; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these changes? have they been removed from the latest generator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, they are removed
No description provided.