Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump generator versions and add support for --name-mappings #149

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

DmitrySboychakov
Copy link
Contributor

No description provided.

@DmitrySboychakov
Copy link
Contributor Author

@gibahjoe please review. Would you like to see addition changes?

@tjarvstrand
Copy link

@DmitrySboychakov A new version of the OpenAPI generator and cli were just released. Please consider updating this PR so we can get the latest version right away.

It contains some fixes we need so it would be greatly appreciated.

Thanks

@DmitrySboychakov
Copy link
Contributor Author

@tjarvstrand yes, I am aware. I'd like to see the review from @gibahjoe first and I can prepare re-worked and updated PR

@quyenvsp
Copy link
Contributor

Thank you but could you please remove binary file? As I only trust binary file from author

@DmitrySboychakov
Copy link
Contributor Author

@quyenvsp not a problem, but I am awaiting for review from @gibahjoe first.

@gibahjoe
Copy link
Owner

Sorry guys, got busy with studies. This PR looks good. Just a review to get through

/// Makes even arrays that are not listed as being required in your OpenAPI "required"
/// but making them always generate a default value of []
final bool? nullSafeArrayDefault;

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these changes? have they been removed from the latest generator?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, they are removed

@gibahjoe gibahjoe merged commit 2ff3b99 into gibahjoe:master Nov 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants