Skip to content

Commit

Permalink
[fix] the run-if condition for the rocm e2e tests job (openshift#56074)
Browse files Browse the repository at this point in the history
Having the `||` means that even empty string is matched which results to
this job being triggered everytime with any change to the repository.
  • Loading branch information
jstourac authored and giladravid16 committed Sep 5, 2024
1 parent 612502d commit bf56f33
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2567,7 +2567,7 @@ tests:
memory: 200Mi
workflow: ipi-gcp
- as: rocm-notebooks-e2e-tests
run_if_changed: (rocm\/ubi9-python-3.(9|11)\/*)||(jupyter\/datascience\/ubi9-python-3.(9|11)\/*)|(jupyter\/rocm\/pytorch\/ubi9-python-3.(9|11)\/*)||(jupyter\/rocm\/tensorflow\/ubi9-python-3.(9|11)\/*)
run_if_changed: (rocm\/ubi9-python-3.(9|11)\/*)|(jupyter\/datascience\/ubi9-python-3.(9|11)\/*)|(jupyter\/rocm\/pytorch\/ubi9-python-3.(9|11)\/*)|(jupyter\/rocm\/tensorflow\/ubi9-python-3.(9|11)\/*)
steps:
cluster_profile: gcp-opendatahub
test:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3771,7 +3771,7 @@ presubmits:
pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: pull-ci-opendatahub-io-notebooks-main-rocm-notebooks-e2e-tests
rerun_command: /test rocm-notebooks-e2e-tests
run_if_changed: (rocm\/ubi9-python-3.(9|11)\/*)||(jupyter\/datascience\/ubi9-python-3.(9|11)\/*)|(jupyter\/rocm\/pytorch\/ubi9-python-3.(9|11)\/*)||(jupyter\/rocm\/tensorflow\/ubi9-python-3.(9|11)\/*)
run_if_changed: (rocm\/ubi9-python-3.(9|11)\/*)|(jupyter\/datascience\/ubi9-python-3.(9|11)\/*)|(jupyter\/rocm\/pytorch\/ubi9-python-3.(9|11)\/*)|(jupyter\/rocm\/tensorflow\/ubi9-python-3.(9|11)\/*)
spec:
containers:
- args:
Expand Down

0 comments on commit bf56f33

Please sign in to comment.