Escape single colon in names #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some IDA generated names are of the form `[thunk]:funcname`, but the and thus the generated name will be `thunk_:funcname` which is an illegal declaration name. Change the bad c name matching regex to match a single colon (that is, a one which is not a part of a pair). Also replace any occurrence of three or more consecutive colons, as this is also an invalid cpp name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some IDA generated names are of the form
[thunk]:funcname, but the and thus the generated name will bethunk_:funcnamewhich is an illegal declaration name.Change the bad c name matching regex to match a single colon (that is, a one which is not a part of a pair).
Also replace any occurrence of three or more consecutive colons, as this is also an invalid cpp name.
This fixes igogo-x86#79.