Merge pull request #41 from h3llfyre/master

fix error in foreach due to splice
gilgen · Aug 17, 2016 · 2127bf2 · 2127bf2
2 parents 2b10b2e + 5d628ba
commit 2127bf2
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/addon/services/pusher.js b/addon/services/pusher.js
@@ -176,14 +176,15 @@ export default Ember.Service.extend({
     if(typeof eventsToUnwire === 'string') {
       eventsToUnwire = [eventsToUnwire];
     }
-
-    eventBindings.forEach((binding, index) => {
+    let index = eventBindings.length;
+    while (index--){
+      let binding = eventBindings[index];
       if(eventsToUnwire && !eventsToUnwire.contains(binding.eventName)) {
         return;
       }
       channel.unbind(binding.eventName, binding.handler);
       eventBindings.splice(index, 1);
-    });
+    }
 
     if (Ember.isEmpty(eventBindings)) {
       delete bindings[channelName].eventBindings[targetId];