Add tests for tombstones #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipc
force-pushed
the
tombstone
branch
3 times, most recently
from
c546860
to
66519e6
Compare
This covers some but not all cases of tombstones. In particular, we don't have a test for a DW_LNE_set_address tombstone in the middle of a line number sequence. This also handles an integer overflow for a tombstone address in DW_AT_low_pc. We already did the right thing in release builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers some but not all cases of tombstones.
In particular, we don't have a test for a DW_LNE_set_address tombstone in the middle of a line number sequence.
This also handles an integer overflow for a tombstone address in DW_AT_low_pc. We already did the right thing in release builds.