Run rustfmt 0.8.6 #205
Merged
Run rustfmt 0.8.6 #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
approved these changes
Jun 13, 2017
| let debug_abbrev = DebugAbbrev::<LittleEndian>::new(&debug_abbrev); | ||
| test::black_box(unit.abbreviations(debug_abbrev) | ||
| .expect("Should parse abbreviations")); | ||
| }); |
There was a problem hiding this comment.
Bleh... I've tried to figure out how to fix this indentation behavior, haven't found anything that quite does the trick.
| @@ -152,7 +154,8 @@ fn bench_parsing_line_number_program_opcodes(b: &mut test::Bencher) { | |||
| let debug_line = DebugLine::<LittleEndian>::new(&debug_line); | |||
|
|
|||
| b.iter(|| { | |||
| let program = debug_line.program(OFFSET, ADDRESS_SIZE, None, None) | |||
| let program = debug_line | |||
| .program(OFFSET, ADDRESS_SIZE, None, None) | |||
There was a problem hiding this comment.
And why do these ones not get teh same indentation? ...
There was a problem hiding this comment.
This behaviour is controlled by closure_block_indent_threshold, which defaults to 7 lines. So closures of up to 7 lines use visual, and longer closures use block indent. I'd be happy with a setting that made it use the same indentation always.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also enable the rustfmt option to convert
try!()to?. Note that this does cause a small performance regression in FDE parsing (probably the same issue as rust-lang/rust#37939).