Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gin is more and more bloated now #1604

Closed
iiinsomnia opened this issue Oct 23, 2018 · 4 comments
Closed

Gin is more and more bloated now #1604

iiinsomnia opened this issue Oct 23, 2018 · 4 comments

Comments

@iiinsomnia
Copy link

iiinsomnia commented Oct 23, 2018 •
edited
Loading

Description

When go get Gin, it will pull many unnecessary dependences, like grpc、golang.org/x/crypto 、golang.org/x/sys、golang.org/x/lint etc.
@thinkerou
Copy link
Member

go.mod could lead to the issue, I will fix it, thanks!

@thinkerou
Copy link
Member

@iiinsomnia please give me reproduce steps, thanks!

@thinkerou
Copy link
Member

ref: golang/go#28156

@thinkerou thinkerou mentioned this issue Oct 23, 2018
Closed
@thinkerou
Copy link
Member

duplicated #1566

@thinkerou thinkerou mentioned this issue Jan 24, 2019
Merged
appleboy pushed a commit that referenced this issue Jan 25, 2019
@thinkerou @appleboy
chore: attempt to fix some gomod issue (#1751)
d27685e 
#1604 #1566 #1700 #1737 

because some dependencies only are used on example i.e. grpc.

Or migrate `examples` to gin-gonic/examples`?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thinkerou @iiinsomnia