[Bug]mixed param and non-param paths

[waising]

gin version 1.7.2

"/get/abc" = value1
"/get/:param" = value2

GET /get/abc => value1
GET /get/a => value2
GET /get/xyz => value2
GET /get/abcd => 404 (should be value2)

[zihengCat]

@waising
Known issue for wildcard router conflicts. You should avoid writing router rules like this.
Try the following:

router.GET("/api/v1/:param", func(c *gin.Context) {
    if c.Param("param") == "abc" {
        // do something for typical param
    }
    // normal case ...
})

[qm012]

same mistake as #2762

[kszafran]

I wouldn't say it's a "mistake". Isn't this exactly the problem that was supposed to be fixed by the new router?

[appleboy]

@qm012 I can reproduce the issue with the latest commit d4ca9a0

package main

import (
	"fmt"

	"github.com/gin-gonic/gin"
)

func handler01(c *gin.Context) {
	fmt.Println(c.Params)
	c.String(200, "ok01")
}

func handler02(c *gin.Context) {
	fmt.Println(c.Params)
	c.String(200, "ok02")
}

func main() {
	g := gin.Default()
	g.GET("/get/abc", handler01)
	g.GET("/get/:param", handler02)
	g.Run(":9090")
}

result:

/abc  200 ok02
/a    404
/ab   200 ok02
/xyz  200 ok02
/abcd 200 ok02

[qm012]

@appleboy Please give me some time. I am trying to solve this problem. There is no problem with the first-level route match, but if the multi-level route is greater than or less than the current path, it will not match the original one

[appleboy]

@qm012 Thanks.

@waising @zihengCat We move to #2796 for discussion in the fueture.