Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jsonp Support to Context #1333

Merged
merged 7 commits into from
Apr 26, 2018
Merged

Add Jsonp Support to Context #1333

merged 7 commits into from
Apr 26, 2018

Conversation

w169q169
Copy link
Contributor

Jsonp is common format in json to o request data from servers in different domains,
I added Jsonp's data return format.

@codecov
Copy link

codecov bot commented Apr 25, 2018

Codecov Report

Merging #1333 into master will decrease coverage by 0.15%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1333      +/-   ##
==========================================
- Coverage   98.41%   98.26%   -0.16%     
==========================================
  Files          34       34              
  Lines        1772     1790      +18     
==========================================
+ Hits         1744     1759      +15     
- Misses         23       25       +2     
- Partials        5        6       +1
Impacted Files Coverage Δ
render/render.go 100% <ø> (ø) ⬆️
context.go 96.51% <100%> (+0.02%) ⬆️
render/json.go 93.87% <81.25%> (-6.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41f951e...2747152. Read the comment docs.

@@ -861,6 +861,28 @@ func main() {
r.Run(":8080")
}
```
#### JSONP
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add one line at top of API Examples section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I have added documentation.

@appleboy
Copy link
Member

See the screenshot

snip20180425_3

@appleboy appleboy merged commit 8c24018 into gin-gonic:master Apr 26, 2018
@appleboy appleboy added this to the 1.3 milestone Apr 26, 2018
tonyhhyip pushed a commit to ysitd-cloud/gin that referenced this pull request Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants