-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WriteJSON check response write error #1653
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1653 +/- ##
==========================================
+ Coverage 98.48% 99.55% +1.06%
==========================================
Files 41 23 -18
Lines 2042 445 -1597
==========================================
- Hits 2011 443 -1568
+ Misses 19 1 -18
+ Partials 12 1 -11
Continue to review full report at Codecov.
|
@lpxxn Please add the testing case to improve code coverage. |
thinkerou
reviewed
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we need to check w.Write(jsonBytes) error.
there have an case, i have encountered:
when i write wrong number of response Header Content-Length
the w.Write(jsonBytes) will throw an err "http: wrote more than the declared Content-Length"
but gin did not throw the error, and response body is empty