Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support time.Duration on mapping #1794

Merged
merged 2 commits into from
Mar 4, 2019

Conversation

vkd
Copy link
Contributor

@vkd vkd commented Mar 3, 2019

var s struct {
    Timeout time.Duration `form:"timeout"`
}
req := formPostRequest("", "timeout=5s")
Form.Bind(req, &s)

@codecov
Copy link

codecov bot commented Mar 3, 2019

Codecov Report

Merging #1794 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1794      +/-   ##
==========================================
+ Coverage   98.62%   98.62%   +<.01%     
==========================================
  Files          41       41              
  Lines        2103     2112       +9     
==========================================
+ Hits         2074     2083       +9     
  Misses         18       18              
  Partials       11       11
Impacted Files Coverage Δ
binding/form_mapping.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8f1459...8c0a11f. Read the comment docs.

Copy link
Member

@thinkerou thinkerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thinkerou thinkerou added this to the 1.4 milestone Mar 4, 2019
@thinkerou thinkerou merged commit 805b2d4 into gin-gonic:master Mar 4, 2019
@vkd vkd deleted the mapping_time_duration branch March 26, 2019 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants