Propagate request context behaviour to gin context methods implementing stdlib context.Context interface. #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xakep666
force-pushed
the
propagate-request-context
branch
2 times, most recently
from
00a2dd4
to
785d344
Compare
Codecov Report
@@ Coverage Diff @@
## master #1803 +/- ##
==========================================
+ Coverage 98.62% 98.63% +<.01%
==========================================
Files 41 42 +1
Lines 2113 2127 +14
==========================================
+ Hits 2084 2098 +14
Misses 18 18
Partials 11 11
Continue to review full report at Codecov.
|
xakep666
force-pushed
the
propagate-request-context
branch
2 times, most recently
from
edc4df5
to
900325b
Compare
…ng stdlib context.Context interface. It makes possible to correctly cancel handlers when request cancelled (connection closed, etc.) Try to extract value from request context when it was not found in gin context Signed-off-by: Vladimir Stolyarov <[email protected]>
xakep666
force-pushed
the
propagate-request-context
branch
from
900325b
to
b7e79c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes possible to correctly cancel handlers when request cancelled (connection closed, etc.)
Try to extract value from request context when it was not found in gin context