Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #1804 which is caused by calling middleware twice. #1805

Merged
merged 2 commits into from
Mar 11, 2019
Merged

fix #1804 which is caused by calling middleware twice. #1805

merged 2 commits into from
Mar 11, 2019

Conversation

sairoutine
Copy link
Contributor

Fix: #1804

allNoRoute contains middlewares such as gin.Logger, gin.Recovery, so on. The correct code is to use noRoute.

cc: @MetalBreaker

@codecov
Copy link

codecov bot commented Mar 10, 2019

Codecov Report

Merging #1805 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1805   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          41       41           
  Lines        2113     2113           
=======================================
  Hits         2084     2084           
  Misses         18       18           
  Partials       11       11
Impacted Files Coverage Δ
routergroup.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70a0aba...c680dcb. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 10, 2019 •
edited
Loading

Codecov Report

Merging #1805 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1805   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          41       41           
  Lines        2113     2113           
=======================================
  Hits         2084     2084           
  Misses         18       18           
  Partials       11       11
Impacted Files Coverage Δ
routergroup.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70a0aba...541ccac. Read the comment docs.

@thinkerou thinkerou added the bug label Mar 11, 2019
@thinkerou thinkerou added this to the 1.4 milestone Mar 11, 2019
thinkerou
thinkerou approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@thinkerou thinkerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@appleboy appleboy merged commit 4a23c4f into gin-gonic:master Mar 11, 2019
@sairoutine sairoutine deleted the fix_issue_1804 branch March 11, 2019 02:54
@sairoutine
Copy link
Contributor Author

Thank you for your reviews and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkerou thinkerou thinkerou approved these changes

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@sairoutine @appleboy @thinkerou