Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor redirect request in gin.go #1970

Merged
merged 5 commits into from
Nov 26, 2019
Merged

Refactor redirect request in gin.go #1970

merged 5 commits into from
Nov 26, 2019

Conversation

nsiregar
Copy link
Contributor

@nsiregar nsiregar commented Jul 3, 2019

Refactor redirecting request in gin.go since its use the same Context

@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #1970 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1970   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          40       40           
  Lines        2238     2238           
=======================================
  Hits         2207     2207           
  Misses         16       16           
  Partials       15       15
Impacted Files Coverage Δ
binding/form.go 100% <ø> (ø) ⬆️
gin.go 98.28% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c8e29b...9ec65d6. Read the comment docs.

@appleboy appleboy added this to the 1.5 milestone Sep 3, 2019
@thinkerou thinkerou modified the milestones: 1.5, 1.6 Oct 31, 2019
@thinkerou thinkerou merged commit 231ff00 into gin-gonic:master Nov 26, 2019
ThomasObenaus pushed a commit to ThomasObenaus/gin that referenced this pull request Feb 19, 2020
* Refactor redirect request in gin.go

* Update http status code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants