Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate binding body tests #2086

Merged
merged 2 commits into from
Oct 10, 2019
Merged

Relocate binding body tests #2086

merged 2 commits into from
Oct 10, 2019

Conversation

vkd
Copy link
Contributor

@vkd vkd commented Oct 6, 2019

Every test file should be related to a tested file.
Remove useless tests.

Every test file should be related to a tested file.
Remove useless tests.
"testing"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need the package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, I've added that package in vendor file.

That package helps us to show an useful test output on error cases. In case when we see assert's message of err != nil, the message about field's value is not equals says nothing helpful.

@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #2086 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2086   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files          40       40           
  Lines        2229     2229           
=======================================
  Hits         2205     2205           
  Misses         12       12           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fd3234...db891a9. Read the comment docs.

@thinkerou thinkerou added this to the 1.5 milestone Oct 10, 2019
@thinkerou thinkerou merged commit f7becac into gin-gonic:master Oct 10, 2019
@vkd vkd deleted the binding-tests branch October 11, 2019 05:31
ThomasObenaus pushed a commit to ThomasObenaus/gin that referenced this pull request Feb 19, 2020
* Relocate binding body tests

Every test file should be related to a tested file.
Remove useless tests.

* Add github.com/stretchr/testify/require package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants