fix(router): tree bug where loop index is not decremented. #3460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3460 +/- ##
=======================================
Coverage 98.63% 98.63%
=======================================
Files 42 42
Lines 3140 3140
=======================================
Hits 3097 3097
Misses 29 29
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
thinkerou
reviewed
Jan 4, 2023
thinkerou
reviewed
Jan 4, 2023
thinkerou
reviewed
Jan 4, 2023
kristiansvalland
force-pushed
the
fix/3459
branch
from
f4dfe65
to
3bda7d8
Compare
Also add test to validate fix. fixes gin-gonic#3459 Signed-off-by: Kristian Svalland <[email protected]>
kristiansvalland
force-pushed
the
fix/3459
branch
from
3bda7d8
to
fd8bbdc
Compare
appleboy
approved these changes
Jan 7, 2023
appleboy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add test to validate fix.
fixes #3459