Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(lint): enable testifylint linter #4010

Merged
merged 1 commit into from
Jul 14, 2024
Merged

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Jul 7, 2024

This PR enables and fixes testifylint linter to use best practices concerning testify

Signed-off-by: Matthieu MOREL <[email protected]>
Copy link

codecov bot commented Jul 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.06%. Comparing base (3dc1cd6) to head (72b21b3).
Report is 65 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4010      +/-   ##
==========================================
- Coverage   99.21%   99.06%   -0.16%     
==========================================
  Files          42       44       +2     
  Lines        3182     2772     -410     
==========================================
- Hits         3157     2746     -411     
+ Misses         17       15       -2     
- Partials        8       11       +3     
Flag Coverage Δ
?
-tags "sonic avx" 99.05% <ø> (?)
-tags go_json 99.05% <ø> (?)
-tags nomsgpack 99.04% <ø> (?)
go-1.18 ?
go-1.19 ?
go-1.20 ?
go-1.21 99.06% <ø> (-0.16%) ⬇️
go-1.22 99.06% <ø> (?)
macos-latest 99.06% <ø> (-0.16%) ⬇️
ubuntu-latest 99.06% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35
Copy link
Contributor Author

@thinkerou , @appleboy ,
Would you like to review this pr ?

@appleboy appleboy changed the title enable testifylint linter ci(lint): enable testifylint linter Jul 14, 2024
@appleboy appleboy added this to the v1.11 milestone Jul 14, 2024
@appleboy appleboy merged commit 5f55c6a into gin-gonic:master Jul 14, 2024
24 of 25 checks passed
@mmorel-35 mmorel-35 deleted the testifylint branch July 14, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants