Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type errors #20

Merged
merged 3 commits into from
May 31, 2020
Merged

fix type errors #20

merged 3 commits into from
May 31, 2020

Conversation

lkapelevich
Copy link
Contributor

Random.seed!(1)
p = rand(Float32, 4)
PolynomialRoots.roots(p)

was running into:

ERROR: MethodError: no method matching eval_poly_der2_ek(::Complex{Float64}, ::Array{Complex{Float32},1}, ::Int64, ::Complex{Float32})
Closest candidates are:
  eval_poly_der2_ek(::T, ::AbstractArray{T,1}, ::Any, ::Any) where T<:Complex at /home/hypatia/.julia/dev/PolynomialRoots/src/PolynomialRoots.jl:121
Stacktrace:
 [1] laguerre2newton(::Array{Complex{Float32},1}, ::Int64, ::Complex{Float32}, ::Int64, ::Float32) at /home/hypatia/.julia/dev/PolynomialRoots/src/PolynomialRoots.jl:349
 [2] roots!(::Array{Complex{Float32},1}, ::Array{Complex{Float32},1}, ::Float64, ::Int64, ::Bool) at /home/hypatia/.julia/dev/PolynomialRoots/src/PolynomialRoots.jl:588
 [3] roots(::Array{Float32,1}; epsilon::Float64, polish::Bool) at /home/hypatia/.julia/dev/PolynomialRoots/src/PolynomialRoots.jl:630
 [4] roots(::Array{Float32,1}) at /home/hypatia/.julia/dev/PolynomialRoots/src/PolynomialRoots.jl:623
 [5] top-level scope at REPL[46]:1

@giordano
Copy link
Owner

Awesome, thank you so much!

@giordano giordano merged commit 1e12379 into giordano:master May 31, 2020
@lkapelevich lkapelevich deleted the fixtypes branch June 1, 2020 00:21
@lkapelevich
Copy link
Contributor Author

@giordano would you mind tagging this?

@giordano
Copy link
Owner

giordano commented Jun 1, 2020

This is already in v1.0.0 🙂

@lkapelevich
Copy link
Contributor Author

oops I missed that. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants