-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix ValueError on Topic update by anonymous poster
- Loading branch information
1 parent
d47ef54
commit 2392153
Showing
2 changed files
with
48 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,7 +22,7 @@ | |
TopicFactory, | ||
) | ||
from lacommunaute.forum_conversation.forms import PostForm | ||
from lacommunaute.forum_conversation.models import Topic | ||
from lacommunaute.forum_conversation.models import Post, Topic | ||
from lacommunaute.forum_conversation.views import PostDeleteView, TopicCreateView | ||
from lacommunaute.forum_upvote.factories import UpVoteFactory | ||
from lacommunaute.notification.factories import BouncedDomainNameFactory, BouncedEmailFactory | ||
|
@@ -323,6 +323,44 @@ def test_topic_update_with_html_content(self, *args): | |
self.assertFalse(self.topic.first_post.approved) | ||
self.assertEqual("HTML tags detected", self.topic.first_post.update_reason) | ||
|
||
def test_update_by_anonymous_user(self): | ||
response = self.client.post( | ||
reverse( | ||
"forum_conversation:topic_create", | ||
kwargs={ | ||
"forum_slug": self.forum.slug, | ||
"forum_pk": self.forum.pk, | ||
}, | ||
), | ||
{"subject": "subject", "content": "La communauté", "username": "[email protected]"}, | ||
) | ||
post = Post.objects.select_related("topic").get(username="[email protected]") | ||
topic = post.topic | ||
response = self.client.post( | ||
reverse( | ||
"forum_conversation:topic_update", | ||
kwargs={ | ||
"forum_slug": self.forum.slug, | ||
"forum_pk": self.forum.pk, | ||
"slug": topic.slug, | ||
"pk": topic.pk, | ||
}, | ||
), | ||
{"subject": "subject", "content": "La communauté", "username": "[email protected]"}, | ||
) | ||
self.assertRedirects( | ||
response, | ||
reverse( | ||
"forum_conversation:topic", | ||
kwargs={ | ||
"forum_slug": self.forum.slug, | ||
"forum_pk": self.forum.pk, | ||
"slug": topic.slug, | ||
"pk": topic.pk, | ||
}, | ||
), | ||
) | ||
|
||
@patch("machina.apps.forum_conversation.views.TopicUpdateView.perform_permissions_check", return_value=True) | ||
def test_topic_update_with_bounced_domain_name(self, *args): | ||
# TO BE FIXED : this test won't work until the update topic as anonymous user is fixed | ||
|