Fix ValueError on Topic update by anonymous poster

https://itou.sentry.io/issues/4265102886/

lacommunaute/forum_conversation/forms.py

@@ -57,3 +57,12 @@ def save(self):
 
         post.topic.save()
         return post
+
+    def update_post(self, post):
+        if self.user.is_anonymous:
+            post.username = self.cleaned_data["username"]
+            if should_not_be_approved(self.cleaned_data["username"]):
+                post.approved = False
+        else:
+            post.updated_by = self.user
+        post.updates_count = F("updates_count") + 1

lacommunaute/forum_conversation/tests/tests_views.py

@@ -22,7 +22,7 @@
     TopicFactory,
 )
 from lacommunaute.forum_conversation.forms import PostForm
-from lacommunaute.forum_conversation.models import Topic
+from lacommunaute.forum_conversation.models import Post, Topic
 from lacommunaute.forum_conversation.views import PostDeleteView, TopicCreateView
 from lacommunaute.forum_upvote.factories import UpVoteFactory
 from lacommunaute.notification.factories import BouncedDomainNameFactory, BouncedEmailFactory
@@ -323,6 +323,44 @@ def test_topic_update_with_html_content(self, *args):
         self.assertFalse(self.topic.first_post.approved)
         self.assertEqual("HTML tags detected", self.topic.first_post.update_reason)
 
+    def test_update_by_anonymous_user(self):
+        response = self.client.post(
+            reverse(
+                "forum_conversation:topic_create",
+                kwargs={
+                    "forum_slug": self.forum.slug,
+                    "forum_pk": self.forum.pk,
+                },
+            ),
+            {"subject": "subject", "content": "La communauté", "username": "[email protected]"},
+        )
+        post = Post.objects.select_related("topic").get(username="[email protected]")
+        topic = post.topic
+        response = self.client.post(
+            reverse(
+                "forum_conversation:topic_update",
+                kwargs={
+                    "forum_slug": self.forum.slug,
+                    "forum_pk": self.forum.pk,
+                    "slug": topic.slug,
+                    "pk": topic.pk,
+                },
+            ),
+            {"subject": "subject", "content": "La communauté", "username": "[email protected]"},
+        )
+        self.assertRedirects(
+            response,
+            reverse(
+                "forum_conversation:topic",
+                kwargs={
+                    "forum_slug": self.forum.slug,
+                    "forum_pk": self.forum.pk,
+                    "slug": topic.slug,
+                    "pk": topic.pk,
+                },
+            ),
+        )
+
     @patch("machina.apps.forum_conversation.views.TopicUpdateView.perform_permissions_check", return_value=True)
     def test_topic_update_with_bounced_domain_name(self, *args):
         # TO BE FIXED : this test won't work until the update topic as anonymous user is fixed