Recommandations #512
Merged
Recommandations #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoisfreitag
force-pushed
the
ff/surveys
branch
7 times, most recently
from
8885c1f
to
457a398
Compare
|
@vincentporte Voilà un début de système de recommendations (complètement inutiles 🙈). Par rapport à la version initiale :
|
francoisfreitag
force-pushed
the
ff/surveys
branch
4 times, most recently
from
89f652d
to
f8c04d3
Compare
|
On merge “en l’état” et on itère : https://mattermost.incubateur.net/betagouv/pl/dtgkutcrg38qj8yxb7tjeyiewa |
francoisfreitag
force-pushed
the
ff/surveys
branch
2 times, most recently
from
909bdc1
to
17a2b3a
Compare
The eventual goal is to make recommendations for DORA services. For the first iteration, it simply outputs some text to guide professionals on the next action. The first version is extremely crude, so it’s untested, as most expectations are unknown.
vincentporte
force-pushed
the
ff/surveys
branch
from
d7a6083
to
5f78bc9
Compare
… button, box selected choices
vincentporte
force-pushed
the
ff/surveys
branch
2 times, most recently
from
69a0a8a
to
ff759e5
Compare
francoisfreitag
commented
Feb 8, 2024
francoisfreitag
commented
Feb 8, 2024
Comment on lines
31
to
38
| assertContains(response, '<iframe data-tally-src="https://tally.so/embed') | ||
| assertNotContains(response, '<form method="post">') | ||
|
|
||
| def test_user_has_permission(self, db, client): | ||
| client.force_login(UserFactory(with_perm=[Permission.objects.get(codename="add_dsp")])) | ||
| response = client.get(reverse("surveys:dsp_create")) | ||
| assertContains(response, '<form method="post">') | ||
| assertNotContains(response, '<iframe data-tally-src="https://tally.so/embed') |
There was a problem hiding this comment.
Pour éviter que ces assertions assertNotContains ne tombent en désuetudes, on peut utiliser un attribut sur la classe.
Exemple :
form_html = '<form method="post">'
tally_html = '<iframe data-tally-src="https://tally.so/embed'
def test_user_has_no_permission(self, db, client):
# ...
assertContains(response, self.tally_html)
assertNotContains(response, self.form_html)
def test_user_has_permission(self, db, client):
# ...
assertContains(response, self.form_html)
assertNotContains(response, self.tally_html)
vincentporte
force-pushed
the
ff/surveys
branch
from
ff759e5
to
005300a
Compare
vincentporte
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recommander des actions suite au diagnostic parcours IAE. Pour le moment, simplissime : une réponse correspond à une recommendations.
Gestion des accès avec la permission
surveys.add_dspTODO
Closes #511