-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(forum_conversation/tests.py): test explicite pour la seconde page #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calummackervoy
force-pushed
the
667-pagination-et-tags
branch
from
June 11, 2024 12:59
d265dc9
to
369eaf7
Compare
calummackervoy
commented
Jun 11, 2024
Comment on lines
+959
to
+969
TopicFactory.create_batch(10, with_post=True, forum=self.forum) | ||
response = self.client.get(self.url + "?page=2") | ||
self.assertContains( | ||
response, | ||
( | ||
f'<a href="{self.url}?tags={tag.slug}&page=1">' | ||
'<span class="badge badge-xs rounded-pill bg-info-lighter ' | ||
f'text-info">{ tag.name }</span></a>' | ||
), | ||
status_code=200, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Désolé @vincentporte j'avais raté que la branche remote n'était pas à jour quand j'ai mergé le PR #668 🤦
vincentporte
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯
vincentporte
pushed a commit
that referenced
this pull request
Jun 13, 2024
🤖 I have created a release *beep* *boop* --- ## [2.10.0](v2.9.2...v2.10.0) (2024-06-13) ### Features * **admin:** ajoute PostInline à TopicAdmin ([#657](#657)) ([6f3049a](6f3049a)) * ajout du chemin de fer dans l'espace d'échanges et la documentation ([#649](#649)) ([7cc5d14](7cc5d14)) * **forum_conversation/admin:** CertifiedPost verbose_name et traduction ([#666](#666)) ([e9b0da6](e9b0da6)) * **forum_conversation/tests.py:** test explicite pour la seconde page ([#669](#669)) ([5bea4f1](5bea4f1)) * **forum_conversation:** remettre les annonces dans la liste des messages par défaut ([#662](#662)) ([bb341cb](bb341cb)) * **forum_moderation:** enregistrement des messages bloquées ([#659](#659)) ([7318b5d](7318b5d)) * **forum:** harmoniser la liste des topics ([#665](#665)) ([6f8bf3c](6f8bf3c)) * **stats:** afficher les stats quotidiennes des Diagnostics Parcours IAE ([#660](#660)) ([5c74c56](5c74c56)) * **stats:** ajout de la vue historique des visiteurs mensuels ([#656](#656)) ([804be3c](804be3c)) * **stats:** collecter le nombre de diag parcours iae réalisés quotidiennement ([#658](#658)) ([7205a2b](7205a2b)) ### Bug Fixes * **documentation:** améliorer l'affichage des bannières des fiches pratiques ([#653](#653)) ([3b539d2](3b539d2)) * **forum_conversation:** page 1 forcée dans les liens tags ([#668](#668)) ([a150ab2](a150ab2)) * **forum_moderation:** motif de blocage illisible dans l'admin ([#672](#672)) ([5480394](5480394)) * **quality:** formatage des balises `script` dans le gabarit `base.html` ([#651](#651)) ([0be3c8b](0be3c8b)) * **stats:** corrections mineures ([#661](#661)) ([d3ae4fd](d3ae4fd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🎸 Ajout d'un test
Type de changement
🚧 technique