Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable DBus sample #87

Merged
merged 5 commits into from
Oct 28, 2020
Merged

Enable DBus sample #87

merged 5 commits into from
Oct 28, 2020

Conversation

badcel
Copy link
Member

@badcel badcel commented Oct 25, 2020

Fixes #84

@mjakeman
Copy link
Member

I'll try and have a look at this a bit later.

Rather than merge this into GenerateSignals, should we merge #75 first, and then this into develop?

Base automatically changed from GenerateSignals to GenerateGObject October 26, 2020 18:44
Base automatically changed from GenerateGObject to GenerateV2 October 26, 2020 18:49
Base automatically changed from GenerateV2 to CustomGObjects October 26, 2020 19:58
Base automatically changed from CustomGObjects to develop October 26, 2020 20:09
@badcel badcel requested a review from a team October 27, 2020 06:19
mjakeman
mjakeman approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@mjakeman mjakeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

This looks good to me. It's better that we're doing changes like making enums use PascalCase sooner rather than later.

@badcel badcel merged commit 43e1ceb into develop Oct 28, 2020
@badcel badcel deleted the Fix_84 branch October 28, 2020 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjakeman mjakeman mjakeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable DBus samples
2 participants
@badcel @mjakeman