Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] React component failed to build #783

Closed
MuYunyun opened this issue Nov 18, 2022 · 1 comment
Closed

[bug] React component failed to build #783

MuYunyun opened this issue Nov 18, 2022 · 1 comment

Comments

@MuYunyun
Copy link

MuYunyun commented Nov 18, 2022

What happened?

When I update giscus-react from 2.2.2 to 2.2.3, my react project building crashed:

image

I'm not sure if my case is the same with #782.

Debug

I'm using Giscus in such way:

const Giscus = require('@giscus/react')

Then I print 'Giscus' in project with console.log:

image

giscus-react in 2.2.2 it prints a function as follow:

image

giscus-react in 2.2.3 it prints a path as follow:

image

Environment

Software Version(s)
React 18.0.0
Node 16.13.0

Others

【advice】If the build product changes commit, is it better to upgrade with BREAK CHANGE?

github-actions bot added a commit to MuYunyun/create-react-doc that referenced this issue Nov 18, 2022
@laymonage
Copy link
Member

Fixed in #810, released in v2.2.4.

MuYunyun added a commit to MuYunyun/create-react-doc that referenced this issue Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants