Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax adjustments to avoid editor highlighting bugs #20

Merged
merged 1 commit into from
Nov 11, 2018

Conversation

chrstphrchvz
Copy link
Contributor

This commit uses functionally-equivalent syntax to avoid triggering syntax highlighting bugs in TextMate and any editors/IDEs reusing its rules (e.g. Atom and VS Code).

There's a few highlighting bugs (some specifically for Perl regex) already reported a while ago, but I haven't found if any of those are what Makefile.PL were triggering: https://github.com/textmate/perl.tmbundle/issues

Prevent triggering syntax highlighting bugs in editors using TextMate's rules
@chrstphrchvz
Copy link
Contributor Author

Some screenshots of the issues:

screen shot 2018-11-11 at 2 11 47 am

screen shot 2018-11-11 at 2 12 16 am

screen shot 2018-11-11 at 2 12 43 am

@vadrer vadrer merged commit 8048394 into gisle:master Nov 11, 2018
@vadrer
Copy link
Collaborator

vadrer commented Nov 11, 2018

thank you, looks good

@chrstphrchvz chrstphrchvz deleted the tm-workarounds branch November 11, 2018 08:57
@chrstphrchvz
Copy link
Contributor Author

textmate/perl.tmbundle#25: another workaround would have been to put a space between regex /^MSWin32|…|openbsd$/ and ternary operator ? 1 : 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants