-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warning: invalid credential line: Opening in existing browser session. #178
Comments
Hi @jglick, thanks for reporting this issue! Can I ask a few questions to help diagnose the problem further?
From first glance, it looks like the browser wrote the line "Opening in existing browser session." to stdout, which It's possible GCM Core may need to launch the browser and detach it from the existing stdin/out. |
Ubuntu 20.04, as mentioned initially. Using Xubuntu (XFCE).
To GitHub or my desktop? Neither.
No.
Chromium (snap).
Yes.
Indeed $ xdg-open https://www.google.com/
Opening in existing browser session. No such message appears in https://github.com/freedesktop/xdg-utils/blob/0547886c0a7ae79145998495a6e3af6a1450d0c7/scripts/xdg-open.in so I am guessing this is part of Chromium though https://github.com/chromium/chromium/search?q=%22existing+browser+session%22 turns up nothing. |
Thanks for the info @jglick! I'll try and repro this and work out a fix. |
Hi @jglick, I've merged in a fix for this, and tested this using Chromium and now didn't get the extra output written. The next release will include this fix, or you can build the latest default branch with |
Hey @jglick, a pre-release is out with this fix now: https://github.com/microsoft/Git-Credential-Manager-Core/releases/tag/v2.0.249-beta |
Thanks, it works! After some testing I have decided not to use it, however, because it is noticeably slower than the built-in
and
the delay goes up from ~500ms to ~1500ms. It seems the program startup time is a bit slower than a C binary, but most of the time appears to be spent contacting the credentials service:
to
and
to
That second delay (some 50ms) seems particularly silly since there is nothing to store: I am already logged in. |
…and since then I have just switched to [credential "https://github.com"]
helper =
helper = !/usr/bin/gh auth git-credential |
This version allows us to update existing `winget` manifests by specifying a manifest's SHA if it already exists in `microsoft/winget-pkgs`. Pull Requests --------------- * [#178](mjcheetham/update-winget#179): Allow updatesto existing winget manifests
This version allows us to update existing `winget` manifests by specifying a manifest's SHA if it already exists in `microsoft/winget-pkgs`. Pull Requests --------------- * [git-ecosystem#178](mjcheetham/update-winget#179): Allow updates to existing winget manifests
Which version of GCM Core are you using?
Git Credential Manager version 2.0.246-beta+7988edd300 (Linux, .NET Core 3.1.8)
Which Git host provider are you trying to connect to?
Can you access the remote repository directly in the browser using the remote URL?
Expected behavior
I am authenticated and my Git operation completes successfully.
Actual behavior
I am prompted to authenticate the app in my browser. I do so, and get a confirmation screen saying I may close my tab and go back to the app. But I am still prompted for a password:
If I try again, the same happens, though now the browser tab immediately claims I am already authenticated.
Logs
The text was updated successfully, but these errors were encountered: