Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use macos-latest image for CI builds #803

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

mjcheetham
Copy link
Collaborator

The macos-10.15 image for CI builds is deprecated on GitHub Actions. We
should update this to a supported image.

Given we are actually running our release builds on macos-latest, we
should probably be running CI on the same image too!

Fixes #802

The macos-10.15 image for CI builds is deprecated on GitHub Actions. We
should update this to a supported image.

Given we are actually running our release builds on macos-latest, we
should probably be running CI on the same image too!
Copy link
Collaborator

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I guess we only have to be mindful when new generations of macos-* build agents become available, and pivot quickly if builds require corresponding adjustments.

@dscho
Copy link
Collaborator

dscho commented Jul 25, 2022

@mjcheetham FYI I adjusted the branch protections accordingly.

@dscho
Copy link
Collaborator

dscho commented Jul 25, 2022

@mjcheetham FYI I adjusted the branch protections accordingly.

I guess we'll want to require the CodeQL checks, too, right?

@mjcheetham
Copy link
Collaborator Author

Looks good! I guess we only have to be mindful when new generations of macos-* build agents become available, and pivot quickly if builds require corresponding adjustments.

Yeah. The CLR abstracts most of the OS, but for the direct native interop bits that we use it'd be good to get early breakages for anything that needs reaction.

@dscho
Copy link
Collaborator

dscho commented Jul 25, 2022

Looks good! I guess we only have to be mindful when new generations of macos-* build agents become available, and pivot quickly if builds require corresponding adjustments.

Yeah. The CLR abstracts most of the OS, but for the direct native interop bits that we use it'd be good to get early breakages for anything that needs reaction.

Done.

@mjcheetham mjcheetham merged commit 162d657 into git-ecosystem:main Jul 25, 2022
@mjcheetham mjcheetham deleted the macos-latest branch July 26, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCM GitHub CI uses deprecated MacOS environment
2 participants