Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: align with dotnet distros #953

Merged
merged 2 commits into from
Nov 8, 2022
Merged

linux: align with dotnet distros #953

merged 2 commits into from
Nov 8, 2022

Conversation

ldennington
Copy link
Contributor

@ldennington ldennington commented Nov 8, 2022 •
edited
Loading

Update install-from-source.sh and validate-install-from-source.yml to align with dotnet-supported Linux distributions. Clarify in README.md that the dotnet-supported distributions are the only ones for which GCM guarantees support.

Link to successful validation workflow:

https://github.com/ldennington/git-credential-manager/actions/runs/3415831593

@ldennington
install-from-source: align with dotnet-supported distros
a70bc23 
Update install-from-source script to align with dotnet's supported Linux
distributions:

https://learn.microsoft.com/en-us/dotnet/core/install/linux
@ldennington ldennington self-assigned this Nov 8, 2022
docs: udpate comment on supported distros
ecddd77 
Update comment around GCM-supported distributions in README.md to reflect
decision to align with dotnet-supported distributions.
derrickstolee
derrickstolee approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is excellent. I'm really happy to see this beautiful job list in your test run of the workflow:
image

@ldennington ldennington merged commit 73654ae into git-ecosystem:main Nov 8, 2022
@ldennington ldennington mentioned this pull request Nov 8, 2022
Closed
@ldennington ldennington mentioned this pull request Nov 16, 2022
Merged
ldennington added a commit that referenced this pull request Nov 16, 2022
@ldennington
Release (#961)
c7c3598 
Changes:

- Convert issue templates to YAML
(24ae90a)
- Replace netstandard2.0 with dotnet6.0
(65cead2)
- Ensure correct installation directory resolution for all OSes and
distribution methods (#951)
- Align with dotnet-supported Linux distributions (#953)
@ldennington ldennington deleted the align-with-dotnet-distros branch July 12, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrickstolee derrickstolee derrickstolee approved these changes

@vtbassmatt vtbassmatt vtbassmatt approved these changes

@mjcheetham mjcheetham Awaiting requested review from mjcheetham

Assignees

@ldennington ldennington

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ldennington @derrickstolee @vtbassmatt